[Purplegaze]

Proposed Changes

Currently, the colour of hybrid nodes clashes a lot with the background change that happens when selecting a focus: the darkened background renders a hybrid node's rect colour almost invisible, while the text colour is very vibrant compared to regular inactivenodes.

This change fixes this visual clash by updating the colour of hybrid nodes to a "light rect/dark text" scheme so they visually interact with a darkened background in a similar way to regular nodes, and now differentiates hybrid nodes with italic text and a solid border instead of light text.

Implementation note: Currently, nodes are being detected as Hybrid based on if they have fill colour #888888 in the SVG, and this was carrying over to the nodes themselves as inline CSS and overriding any style rules. This PR keeps SVG parsing the same, but removes the fill colour of hybrid nodes when inserting them into the database, which allows the style rules defined in app.scss to take effect.

Screenshots:

note: colours may be slightly off because my laptop adds a filter to screenshots for some reason

Before

After

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type	Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
✨ New feature (non-breaking change that adds functionality)
🐛 Bug fix (non-breaking change that fixes an issue)
🎨 User interface change (change to user interface; provide screenshots)	X
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests)
📦 Dependency update (change that updates a dependency)
🔧 Internal (change that only affects developers or continuous integration)

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

• I have performed a self-review of my changes.
  • Check that all changed files included in this pull request are intentional changes.
  • Check that all changes are relevant to the purpose of this pull request, as described above.
• I have added tests for my changes, if applicable.
  • This is required for all bug fixes and new features.
• I have updated the project documentation, if applicable.
  • This is required for new features.
• If this is my first contribution, I have added myself to the list of contributors.
• I have updated the project Changelog (this is required for all changes).

After opening your pull request:

• I have verified that the CI checks have passed.
• I have reviewed the test coverage changes reported by Coveralls.
• I have requested a review from a project maintainer.

Questions and Comments

(Include any questions or comments you have regarding your changes.)
It doesn't look like there are currently any database tests for SVG parsing, only for intersection detection. Let me know if I need to add tests for the Parser.hs change somehow.

[coveralls]

Coverage Report for CI Build 40008577191

Coverage increased (+0.01%) to 60.392%

Details

• Coverage increased (+0.01%) from the base build.
• Patch coverage: 1 uncovered change across 1 file (5 of 6 lines covered, 83.33%).
• No coverage regressions found.

Uncovered Changes

File	Changed	Covered	%
app/Svg/Parser.hs	6	5	83.33%

Coverage Regressions

No coverage regressions found.

---

Coverage Stats

Relevant Lines:	4309
Covered Lines:	2661
Line Coverage:	61.75%
Relevant Branches:	1003
Covered Branches:	547
Branch Coverage:	54.54%
Branches in Coverage %:	Yes
Coverage Strength:	157.09 hits per line

---

💛 - Coveralls