Skip to content

Refactor Times to Time - #1820

Open
PeanutPiglet wants to merge 7 commits into
Courseography:masterfrom
PeanutPiglet:refactor-times-to-time
Open

PeanutPiglet wants to merge 7 commits into
Courseography:masterfrom
PeanutPiglet:refactor-times-to-time

Conversation

@PeanutPiglet

@PeanutPiglet PeanutPiglet commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Proposed Changes

Renames Times database table to Time. Adds a v6 migration to Database/Migration.hs.
Updates references and comments in the backend + backend-test. Also update accessor functions from timesX to timeX.

...

Screenshots of your changes (if applicable)

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
✨ New feature (non-breaking change that adds functionality)
🐛 Bug fix (non-breaking change that fixes an issue)
🎨 User interface change (change to user interface; provide screenshots)
♻️ Refactoring (internal change to codebase, without changing functionality) X
🚦 Test update (change that only adds or modifies tests)
📦 Dependency update (change that updates a dependency)
🔧 Internal (change that only affects developers or continuous integration)

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

  • I have performed a self-review of my changes.
    • Check that all changed files included in this pull request are intentional changes.
    • Check that all changes are relevant to the purpose of this pull request, as described above.
  • I have added tests for my changes, if applicable.
    • This is required for all bug fixes and new features.
  • I have updated the project documentation, if applicable.
    • This is required for new features.
  • If this is my first contribution, I have added myself to the list of contributors.
  • I have updated the project Changelog (this is required for all changes).

After opening your pull request:

  • I have verified that the CI checks have passed.
  • I have reviewed the test coverage changes reported by Coveralls.
  • I have requested a review from a project maintainer.

Questions and Comments

(Include any questions or comments you have regarding your changes.)

@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 39529402909

Coverage decreased (-0.004%) to 60.377%

Details

  • Coverage decreased (-0.004%) from the base build.
  • Patch coverage: 2 uncovered changes across 2 files (13 of 15 lines covered, 86.67%).
  • 11 coverage regressions across 3 files.

Uncovered Changes

File Changed Covered %
app/Database/Migrations.hs 2 1 50.0%
app/Models/Meeting.hs 8 7 87.5%
Total (3 files) 15 13 86.67%

Coverage Regressions

11 previously-covered lines in 3 files lost coverage.

File Lines Losing Coverage Coverage
app/Models/Meeting.hs 6 74.77%
app/WebParsing/UtsgJsonParser.hs 3 28.0%
app/Models/Time.hs 2 64.29%

Coverage Stats

Coverage Status
Relevant Lines: 4309
Covered Lines: 2660
Line Coverage: 61.73%
Relevant Branches: 1001
Covered Branches: 546
Branch Coverage: 54.55%
Branches in Coverage %: Yes
Coverage Strength: 156.97 hits per line

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants