Repository navigation
Conversation
Cover changes, changes_to_save, saved_changes and previous_changes, for single and multiple ids, find_by_id and strict loading. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
pimpin
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Extend the regression specs so that models returned by
findare verified clean on every change-tracking API.Why
BEAR-1793:
findused to return models with pending changes. It is fixed since 2023 (reset_object!inBase.find), but the spec only assertedchanged?.How
New
clean state after findblock inspec/base_spec.rb. Each case assertschanged?,changes,changes_to_save,saved_changesandprevious_changesare empty:find_by_idfind(..., with_strict_loading: true)Evidence of Testing
Syntax checked with
ruby -c. Specs not run locally: they need a Couchbase server. CI is the first real run.Review Focus
Whether the covered APIs and cases are enough.
Documentation
This pull request was created with AI assistance.
🤖 Generated with Claude Code