Skip to content

felt: sqlitedict-pickle-smell — note PYSEC-2026-1939 + Renovate no-op confirmation #799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cailmdaley wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

felt: sqlitedict-pickle-smell — note PYSEC-2026-1939 + Renovate no-op confirmation #799

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .felt/sqlitedict-pickle-smell/sqlitedict-pickle-smell.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,15 @@ tags:
- future
- refactor
created-at: 2026-05-28T09:37:09.591626506+02:00
updated-at: 2026-07-09T17:44:26.53771644+02:00
outcome: Pickle-everywhere in SqliteDict storage (~10 modules) is dismissable today (trusted compute, no external write path) but a real smell. Revisit if shapepipe ever exposes a write path to untrusted .sqlite files.
---

## The vulnerability

`GHSA-g4r7-86gm-pgqc` (high, CVE-2024-35515) — sqlitedict uses pickle as the default value encoding. An attacker who can write `.sqlite` files that shapepipe later reads gets arbitrary code execution on `dict[key]` access, via crafted pickle payloads.
`GHSA-g4r7-86gm-pgqc` (high, CVE-2024-35515) — sqlitedict uses pickle as the default value encoding. An attacker who can write `.sqlite` files that shapepipe later reads gets arbitrary code execution on `dict[key]` access, via crafted pickle payloads. A second OSV advisory, `PYSEC-2026-1939`, covers the same root cause.

`first_patched_version: null`. The maintainer considers pickle-by-default intended behavior; the [README's serialization section](https://github.com/piskvorky/sqlitedict?tab=readme-ov-file#serialization) tells users to pass `encode=`/`decode=` if they care. There will be no upstream fix.
`first_patched_version: null`. The maintainer considers pickle-by-default intended behavior; the [README's serialization section](https://github.com/piskvorky/sqlitedict?tab=readme-ov-file#serialization) tells users to pass `encode=`/`decode=` if they care. There will be no upstream fix — confirmed again 2026-07-09 when Renovate's first live run (post #760 migration) surfaced both advisories via OSV but found no `>2.1.0` release to bump to, so no fix PR was possible. Renovate will keep re-surfacing this on every run (`osvVulnerabilityAlerts: true`); expect it to sit as a perpetual no-op until upstream ships a patch or this fiber's disposition changes.

## How shapepipe uses it

Expand Down