Open
Conversation
vincentdbs
force-pushed
the
feature/add-json-multipart-client
branch
from
e0a6f9b to
1b5ff91
Compare
lucas-amiaud
reviewed
Apr 7, 2026
| */ | ||
| export const jsonContentTypeValidator: FetchResponseHandler = ( | ||
| response: Response, | ||
| ) => validateContentType(response, 'json'); No newline at end of file |
Member
There was a problem hiding this comment.
je sais que c'était fait comme ca avant, mais c'est pas application/json ?
lucas-amiaud
reviewed
Apr 7, 2026
| // ... | ||
| multipartRequest<T>(method: HttpMethod, path: string): MultipartHttpRequest<HttpPromise<T>> { | ||
| return createMultipartHttpFetchRequest<T>(baseUrl, method, path, multipartHttpFetchClient); | ||
| return createMultipartHttpFetchRequest<T>(baseUrl, method, path, defaultJsonMultipartFetchClient); |
Member
There was a problem hiding this comment.
pour le coup je pousserais pas ce client par défaut dans le readme
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Other information: