fix(dsh): read models saved by the provider editor - #92
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
models[]shape and use its first model for the dedicated OpenGUI routemodelsettings and reuse the editor model during interactive credential completionRoot cause
The DSH model editor persists configured models under
coremate-mobile.models, while the plugin only read the legacycoremate-mobile.modelfield. The UI therefore showed a configured provider, butphone_agentcould still enter the missing-model flow.Validation
origin/mainand passes with this change46Vitest files passed,266/266tests passedtsdownbundle completed8/8resolvedgit diff --checkpassedThe full suite was run from a no-space temporary checkout because several existing tests use URL pathnames directly and the maintainer checkout path contains spaces.