Skip to content

fix: correct scene_view positioned capture instructions#1126

Open
davidrynn wants to merge 2 commits into
CoplayDev:betafrom
davidrynn:fix/correct-scene-view-positioned-capture-instructions
Open

fix: correct scene_view positioned capture instructions#1126
davidrynn wants to merge 2 commits into
CoplayDev:betafrom
davidrynn:fix/correct-scene-view-positioned-capture-instructions

Conversation

@davidrynn
Copy link
Copy Markdown

@davidrynn davidrynn commented May 14, 2026

Document that view_position and view_rotation are invalid with capture_source="scene_view", and show the SceneView.LookAt() workflow for taking positioned Scene View screenshots.

Description

Clarifies the Unity MCP skill guidance for taking positioned Scene View screenshots. view_position and view_rotation are not valid with capture_source="scene_view", so the docs now show the correct workflow: move the Scene View with UnityEditor.SceneView.LookAt() first, then capture the Scene View as-is.

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • Documentation update

Changes Made

  • Added a warning that view_position and view_rotation return an error when used with capture_source="scene_view".
  • Added a SceneView.LookAt() example using execute_code to position the Scene View before capture.
  • Clarified that the follow-up manage_camera call should not pass view_target, view_position, or view_rotation when capturing the positioned Scene View as-is.
  • Updated the best-practices note to distinguish unsupported view_position/view_rotation from supported view_target framing.

Testing/Screenshots/Recordings

Not run. Documentation-only change.

Documentation Updates

  • I have added/removed/modified tools or resources
  • If yes, I have updated all documentation files using:
    • The LLM prompt at tools/UPDATE_DOCS_PROMPT.md (recommended)
    • Manual updates following the guide at tools/UPDATE_DOCS.md

Related Issues

None.

Additional Notes

This change does not modify tool behavior. It corrects agent-facing instructions so positioned Scene View screenshots use the supported SceneView.LookAt() workflow.

Summary by CodeRabbit

  • Documentation
    • Clarified that Scene View camera positioning via standard capture operations does not accept framing/positioning parameters; attempting to use them will fail.
    • Added an alternative workflow showing how to reposition the Scene View first (via an execution step) and then capture without framing parameters.
    • Updated best-practices to reflect Scene View compatibility nuances and supported targeting options.

Review Change Stack

Document that view_position and view_rotation are invalid with capture_source="scene_view", and show the SceneView.LookAt() workflow for taking positioned Scene View screenshots.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 14, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 5eb3b7ca-5e36-4d20-9ebe-fbc9ad78799d

📥 Commits

Reviewing files that changed from the base of the PR and between 9f092b0 and ddafba8.

📒 Files selected for processing (1)
  • unity-mcp-skill/SKILL.md
✅ Files skipped from review due to trivial changes (1)
  • unity-mcp-skill/SKILL.md

📝 Walkthrough

Walkthrough

Documentation in unity-mcp-skill/SKILL.md now warns that Scene View capture rejects view_position and view_rotation, and shows examples using execute_code + SceneView.LookAt(...) to reposition the Scene View before capturing. Best-practice bullets updated to reflect scene_view constraints and view_target support.

Changes

Scene View Capture Guidance

Layer / File(s) Summary
Scene View parameter incompatibility guidance
unity-mcp-skill/SKILL.md
Warning added that capture_source="scene_view" rejects view_position and view_rotation; examples show repositioning via execute_code and SceneView.LookAt(...) before capture. Best-practices list updated to note the Scene View incompatibility and that view_target remains supported.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

  • CoplayDev/unity-mcp#1060: Related documentation clarifications for manage_camera parameter interactions and supported viewpoint configurations.
  • CoplayDev/unity-mcp#888: Prior updates to SKILL.md about manage_camera screenshot/camera behavior that overlap with these Scene View docs.

Poem

🐰 I nudged the Scene View with a gentle look,
SceneView.LookAt did the trick in the book,
No position or rotation to pass through,
Reposition first, then capture the view—
Hop, snap, docs done! 📸

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The PR title accurately summarizes the main change: correcting documentation for scene_view positioned capture instructions.
Description check ✅ Passed The PR description covers all required sections: clear summary, type of change, specific changes made, testing notes, documentation updates section, and additional context.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9f092b025f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread unity-mcp-skill/SKILL.md Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant