Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #146.
What changed
WorkspaceStore.dots()issued oneSELECT * FROM dotsfollowed by oneSELECT spaceId FROM dot_spaces WHERE dotId=?per dot — N+1 database round-trips just to list the workspace. It now fetches alldot_spacesrows once and groups them in memory with aMap, cutting the listing down to 2 queries total.Notes
ORDER BY spaceId).spaceIds: []— the grouping keys off the grants table, so a missing entry is an empty list rather than a fallback to a nonexistent column.Testing
tests/workspace.test.ts: seeds dots across multiple spaces (including one with zero grants), asserts the returnedspaceIdsare correct, and assertsdots()issues exactly 2preparecalls (red-checked: fails on unpatched code, which issues N+1).tests/transport.test.tscases, which fail identically on cleanmain.tsc --noEmit,eslint,prettier --checkclean; production build (npm run build) green.