Repository navigation
Conversation
kevin9327
requested review from
MikeRyanDev,
davidmckayv,
guidovizoso,
mxmzb and
tylerslaton
as code owners
October 17, 2026 22:47
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
describeCronrenders a comma list of plain minutes on one hour as "Every day at …", but it did not de-duplicate the minutes. cron-parser fires once per distinct minute, so0,30,0 9 * * *runs at 09:00 and 09:30, yet the routines page and the model were told:weekdays()in the same file already de-duplicates (0,7is said once as "Sundays"); the minute list now does the same with aSetbefore sorting.Where it runs
Boundary and audit
Changelog
CHANGELOG.mdunderUnreleased, at the top; happy to rebase if it conflicts.Proof
New case in
server/tests/routine-schedule.test.ts. On unmodifiedmain:After the fix: 29 pass, 0 fail. Biome check clean on the changed files.
AI assistance: this change was prepared with an AI coding assistant and reviewed and tested by me.