Repository navigation
make_data.py: run the cases only after all case functions are defined - #51
Merged
Merged
Conversation
The __main__ guard sat above dome_label_cases(), so main() called it before the def had run and the script stopped with a NameError. Move the guard to the end of the file. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013bsHH6pfY7QS5ZwURrTZTo
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 29 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
python cpp/tests/data/make_data.pystopped withNameError: name 'dome_label_cases' is not defined. Theif __name__ == "__main__":guard sat abovedef dome_label_cases():, somain()ran before that function existed. The bug is in v1.5.0 and v1.5.1.The guard now sits at the end of the file. Nothing else changes.
cpp/is not in the sdist or the wheel, so the installed package is the same and no changelog entry is needed.cpp/tests/data, because three defaults changed after the files were written:labels.symbols(9272cc7),branding.references(69db666) andbranding.versions(2ea2bf1). With those three set to their old values, the regenerated scenes match the committed ones (item ids and positions). Pinning them inmake_data.pyis a separate follow-up.Generated by Claude Code