Repository navigation
Cycle paths bend exactly on the dome (#47), release checklist with conda-forge - #50
Merged
Merged
Conversation
Only an isobar had its saturation states added. An isotherm now gets them from (T, Q). Isentropes, isenthalps, polytropic paths and isochores get the state on the dome by bisection on the phase, since CoolProp cannot flash s, h or rho together with the quality on both sides of the dome. Equal density is recognised as an isochore; it was drawn as a polytropic path that cut across the dome. "isochoric" is a path kind. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013bsHH8qQUqPxK3TzHzpc72
The releasing page gets a checklist before, during and after a release, and a section on conda-forge: the version pull request of the feedstock after each PyPI release, recipe-only fixes, the test suite there, and the first submission through staged-recipes, as CoolPlot is not on conda-forge yet. MyST task lists are enabled for the checklist. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013bsHH8qQUqPxK3TzHzpc72
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013bsHH8qQUqPxK3TzHzpc72
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 57 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
jowr
added a commit
that referenced
this pull request
Nov 12, 2026
…in 1.5.2 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013bsHH8qQUqPxK3TzHzpc72
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #47, and documents the release process including conda-forge.
Why
A state given with
"via": "isochoric"was followed by a line that was not an isochore.auto_kindchecked p, h, s and T but not rho, so two states of equal density fell through to a polytropic path (linear in log p and s) that cut across the dome.Looking for the same problem elsewhere: only isobars had their saturation states inserted. Every other path kind rounded the corner where it enters or leaves the dome, for example a steam turbine expanding into the wet region (
rankine(),examples/steam_turbine_hs.py).Changes
thermo/cycles/paths.py:_PATH_INPUTS); the old_inner_inputsand_isobar_enthalpiesare replaced by thiscore/cycle.py:"isochoric"is a path kind, andautopicks it for equal density.how_to/cycles.md,contributing/architecture.mdand the changelog.docs/contributing/releasing.md):docs/conf.py: MySTtasklistis enabled for the checklist.Limitation
A path that enters and leaves the dome between two sample points is not seen; a higher
stepsfinds it.Testing
tests/test_cycles.py:PropsSItests/test_cycles.py: 46 passedtest_engine,test_contracts,test_backend_conformance,test_psychro,test_native_core,test_scene_js: 148 passed, 41 skippedsphinx-build -Wwith the newtasklistextension).cpp/tests/dataonly meets the dome at exact points (isobars) or at saturated end states, so it should not change.cpp/tests/data/make_data.pycurrently fails with aNameError(dome_label_casesis called before it is defined); that is separate from this change.Generated by Claude Code