Allow symlinks to phoebus.sh#3845
Merged
shroffk merged 2 commits intoJun 22, 2026
Merged
Conversation
Use realpath to resolve symbolic links to determine where TOP is
Needed if the path contains spaces
shroffk
approved these changes
Jun 22, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the phoebus.sh launcher to correctly resolve the installation directory when the script is invoked via a symlink, and to improve behavior when the installation path contains spaces.
Changes:
- Resolve the script path via
realpathand deriveTOPfrom it (to support symlink-based launches). - Quote
${TOP}incdand quote the computed JAR path when invokingjava. - Quote the
${TOP}prefix used for theproduct-*.jarlookup to better support paths with spaces.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+8
to
+9
| realpath=$(realpath "$0") | ||
| TOP=$(dirname "$realpath") |
| then | ||
| echo "Installing update..." | ||
| cd ${TOP} | ||
| cd "${TOP}" |
|
|
||
|
|
||
| JAR=`echo ${TOP}/product-*.jar` | ||
| JAR=`echo "${TOP}"/product-*.jar` |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting Phoebus using a symlink to
phoebus.shis not possible because the detection where Phoebus was installed fails which means the.jarcannot be found.This PR uses
realpathinstead of thecdandpwd -Ppair to resolve symlinks and convert the path to absolute.There is another problem if the installation path contains spaces; we need to put
${TOP}inside quotes.Checklist