Repository navigation
Update Gradle, Node and dependencies (+ CI fixes) - #46
Merged
Merged
Conversation
actions/cache@v2 has been shut down by GitHub, which makes every build fail. Also update checkout and setup-java (now requires a distribution).
The latest npm no longer supports Node 18, which the build uses.
- gradle-node-plugin 7.1.0, nebula.release 21.1.4 - Property assignment syntax and checkVersion without Task.project at execution time (both fail in Gradle 10) - Empty string instead of null if the publishing tokens are not set (Gradle 9 rejects null command line arguments) - Remove npmInstallVsce: vsce is already installed by npm ci via package.json, the extra install conflicted with npmInstall
- Node 18.17 (end of life) -> 22 LTS - vsce -> @vscode/vsce 4 (vsce was renamed), vscode-test -> @vscode/test-electron (renamed) - TypeScript 5.9 and @types/node 22 - npm audit fix (non-breaking)
- Current versions of the GitHub actions, Node 22 via actions/setup-node - npm 10 pin no longer needed with Node 22 - README: JRE 17 or newer (required by the language server since Xtext 2.42)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependency and build updates, analogous to ContextMapper/context-mapper-dsl#390. To be merged before #44 and #45.
CI fixes (taken over from #44)
actions/cache@v2has been shut down → CI was brokenhttps://central.sonatype.com/repository/maven-snapshots/); OSSRH has been shut downGradle
Task.projectat execution time incheckVersion, empty string instead ofnullif the publishing tokens are not set (Gradle 9 rejectsnullcommand line arguments)npmInstallVsceremoved: vsce is already a dependency inpackage.jsonand installed bynpm ci; the second install collided withnpmInstall(Gradle 9 validation error)Node / npm
vsce→@vscode/vsce4,vscode-test→@vscode/test-electron(samerunTestsAPI)@types/node22 (required by@vscode/test-electron)npm audit fix(non-breaking): 25 → 8 findings. The remaining ones are in dev tools only (mocha10,tslint), not in the packaged extension; fixing them needs mocha 12 and replacing the deprecated tslint (e.g. by ESLint), so I left that for a separate PR.CI workflows
dcodeIO/setup-node-nvm@master→actions/setup-node, Node 22; the npm pin is no longer neededREADME
Verification (local)
./gradlew clean snapshot vscodeExtensionon JDK 17: build, integration test and packaging (.vsix) successful; the bundled LSP is6.12.1-SNAPSHOTfrom the Central Portal (Xtext 2.42, LSP4J 1.0)initializerequest with the expected capabilitiespublish,publishToOpenVSX) can only be tested with a real release