Repository navigation
CI check: 14b fix round 2 (do not merge) - #179
Merged
Merged
Conversation
CI has been red since 14b: - test_plot_network_mass_options compared pixel windows of separate renders bitwise, which software OpenGL on CI does not reproduce. It now checks the mass fractions, the drawn sizes and opacities, the darkness of the faded and interior nodes, and each sphere's measured diameter (with a fixed radius mapping so scale_by_mass shows). - test_results_plot_network_renders / test_results_animate_network_renders looked for the edges at the fitted centers, but the wrappers snap nodes by default; on ubuntu 3.14 the fit moved them out of the 3 px window. They now use display_nodes, the positions actually drawn. - test_plot_network_projects_nodes_into_mask no longer compares two renders bitwise; it measures both spheres' diameters at the effective centers. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ue9wuWfgA8yRXEuEiydTVh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI check only (draft, will be closed). Runs the test matrix on the Task 14b fix round 2 commit: brainnet render tests measure content at the drawn (snapped) node positions instead of comparing separate renders bitwise.
🤖 Generated with Claude Code
https://claude.ai/code/session_01Ue9wuWfgA8yRXEuEiydTVh