Skip to content

fix(cli): return error for non-positive --chunk-size #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Congregalis merged 1 commit into from
Mar 12, 2026
Merged

fix(cli): return error for non-positive --chunk-size #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/cli/run.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -547,7 +547,7 @@ func parseFlags(args []string, stderr io.Writer) (options, error) {
return options{}, errors.New("--max-retries must be 0 or greater")
}
if opts.ChunkSize <= 0 {
opts.ChunkSize = defaultChunkSize
return options{}, errors.New("--chunk-size must be positive")
}

opts.SourceURLs = fs.Args()
Expand Down
10 changes: 10 additions & 0 deletions internal/cli/run_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -520,6 +520,16 @@ func TestParseFlagsRejectsInvalidMaxRetries(t *testing.T) {
}
}

func TestParseFlagsRejectsNonPositiveChunkSize(t *testing.T) {
testCases := []string{"0", "-1"}
for _, value := range testCases {
_, err := parseFlags([]string{"--chunk-size", value, "https://example.com"}, io.Discard)
if err == nil || !strings.Contains(err.Error(), "--chunk-size must be positive") {
t.Fatalf("parseFlags error=%v, want chunk-size validation error for value=%s", err, value)
}
}
}

func TestParseFlagsAllowsVersionWithoutURL(t *testing.T) {
opts, err := parseFlags([]string{"--version"}, io.Discard)
if err != nil {
Expand Down
Loading