Skip to content

Updated the command args for cone tf gen #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
notanthony wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Updated the command args for cone tf gen #100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions cmd/cone/terraform_gen.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,10 @@ const (
tempTfFile = "cone_temp.tf"
)

var objects = []string{"policy", "app_entitlement"}
const appEntitlementArg = "app_entitlements"
const policyArg = "policies"

var objects = []string{policyArg, appEntitlementArg}

func terraformGenCmd() *cobra.Command {
cmd := &cobra.Command{
Expand Down Expand Up @@ -82,7 +85,7 @@ func populateResourcesWithApps(ctx context.Context, c client.C1Client, object st
}

func populateResourcesWithPolicies(ctx context.Context, c client.C1Client, object string, resources map[string]terraform.TemplateData) error {
if object == "policy" || object == "*" {
if object == policyArg || object == "*" {
policies, err := c.ListPolicies(ctx)
if err != nil {
return err
Expand All @@ -96,7 +99,7 @@ func populateResourcesWithPolicies(ctx context.Context, c client.C1Client, objec
}

func populateResourcesWithEntitlements(ctx context.Context, c client.C1Client, v *viper.Viper, object string, resources map[string]terraform.TemplateData) error {
if object == "app_entitlement" || object == "*" {
if object == appEntitlementArg || object == "*" {
appId := v.GetString(tfAppIdFlag)
if appId == "" {
return errors.New("app-id flag is required for app_entitlement object")
Expand All @@ -116,9 +119,9 @@ func populateResourcesWithEntitlements(ctx context.Context, c client.C1Client, v

func getFileName(object string) string {
switch object {
case "app_entitlement":
case appEntitlementArg:
return "generated_app_entitlements.tf"
case "policy":
case policyArg:
return "generated_policies.tf"
case "*":
return "generated_resources.tf"
Expand Down
13 changes: 0 additions & 13 deletions pkg/terraform/templater.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,19 +19,6 @@ type TemplateData interface {
GetOutputId() string
}

func ObjectNameToTerraformType(objectName string) string {
switch objectName {
case "app":
return TerraformAppType
case "policy":
return TerraformPolicyType
case "app_entitlement":
return TerraformAppEntilementType
default:
return ""
}
}

func ApplyTemplate(data TemplateData, tmpl string) (string, error) {
// Prepare a buffer to hold the combined output
var combinedOutput bytes.Buffer
Expand Down