Skip to content

[BB-906] baton-sql-server: delete users when we do account deprovisioning. #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Bencheng21 merged 2 commits into from
Jul 3, 2025
Merged

[BB-906] baton-sql-server: delete users when we do account deprovisioning. #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
41f5bc4
[BB-906] baton-sql-server: delete users instead of disabling users wh…
Bencheng21 Jul 3, 2025
656c0f7
more
Bencheng21 Jul 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/connector/server_user.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ func (d *userPrincipalSyncer) Delete(ctx context.Context, resourceId *v2.Resourc
return nil, err
}

err = d.client.DisableUserFromServer(ctx, user.Name)
err = d.client.DeleteUserFromServer(ctx, user.Name)
if err != nil {
return nil, err
}
Expand Down
4 changes: 2 additions & 2 deletions pkg/mssqldb/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,13 +35,13 @@ func (c *Client) GetServer(ctx context.Context) (*ServerModel, error) {
return &ret, nil
}

func (c *Client) DisableUserFromServer(ctx context.Context, userName string) error {
func (c *Client) DeleteUserFromServer(ctx context.Context, userName string) error {
if strings.ContainsAny(userName, "[]\"';") {
return fmt.Errorf("invalid characters in userName")
}

query := fmt.Sprintf(`
ALTER LOGIN [%s] DISABLE;`, userName)
DROP LOGIN [%s];`, userName)

_, err := c.db.ExecContext(ctx, query)
if err != nil {
Expand Down
Loading