[BB-610] Add account provisioning capability for SQL Server users #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the ability to create SQL Server logins from Windows AD accounts: - Add CreateWindowsLogin method to create SQL Server logins from Windows authentication - Implement AccountManager interface in userPrincipalSyncer - Update baton_capabilities.json to include CREATE_ACCOUNT capability - Add account creation schema with domain and username fields - Update SDK dependencies 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Only create the Windows login without adding users to all databases. Database access should be managed through ConductorOne's access request flow. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Add support for different login types: Windows, SQL Server, Azure AD, and Entra ID - Use FROM EXTERNAL PROVIDER for Azure AD and Entra ID authentication - Improve error handling and validation for different authentication types - Refactor code to use switch statement for better organization 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Remove manual password field in favor of automatic generation - Implement secure random password generator for SQL Server logins - Return generated password as plaintext data - Fix linting issues and improve code organization 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
btipling
force-pushed
the
BB-610-add-account-provisioning
branch
from
834f1b9 to
6fb1785
Compare
Bencheng21
approved these changes
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
SELECT name FROM sys.server_principals WHERE type = 'U'🤖 Generated with Claude Code