Move ImageVectortoXml feature into tools package#883
Conversation
WalkthroughThe pull request restructures the image vector XML conversion feature within the IDE plugin. The feature is being reorganized from the 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/tools/imagevectorxml/conversion/ImageVectorXmlScreen.kt (1)
63-63: Missed rename: private composable functions still useImageVectorToXmlprefix
ImageVectorToXmlContent(line 115) andImageVectorToXmlContentPreview(line 148) were not updated as part of this rename sweep, creating an inconsistency with the rest of the file.♻️ Proposed rename for private functions
- ImageVectorToXmlContent( + ImageVectorXmlContent( state = currentState,`@Composable` -private fun ImageVectorToXmlContent( +private fun ImageVectorXmlContent( state: ImageVectorXmlState.Content,-private fun ImageVectorToXmlContentPreview() = ProjectPreviewTheme { - ImageVectorToXmlContent( +private fun ImageVectorXmlContentPreview() = ProjectPreviewTheme { + ImageVectorXmlContent(Also applies to: 115-115, 148-148
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/tools/imagevectorxml/conversion/ImageVectorXmlScreen.kt` at line 63, Private composable names still use the old ImageVectorToXml prefix; rename the private functions ImageVectorToXmlContent and ImageVectorToXmlContentPreview to match the file's convention (e.g., ImageVectorXmlContent and ImageVectorXmlContentPreview), and update all call sites including the invocation at ImageVectorToXmlContent in ImageVectorXmlScreen.kt and the preview usages so they reference the new names.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In
`@tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/tools/imagevectorxml/conversion/ImageVectorXmlScreen.kt`:
- Line 63: Private composable names still use the old ImageVectorToXml prefix;
rename the private functions ImageVectorToXmlContent and
ImageVectorToXmlContentPreview to match the file's convention (e.g.,
ImageVectorXmlContent and ImageVectorXmlContentPreview), and update all call
sites including the invocation at ImageVectorToXmlContent in
ImageVectorXmlScreen.kt and the preview usages so they reference the new names.
📝 Changelog
If this PR introduces user-facing changes, please update the relevant Unreleased section in changelogs: