Skip to content

Comments

Move ImageVectortoXml feature into tools package#883

Merged
egorikftp merged 1 commit intomainfrom
task/Move-ImageVectortoXml-feature-into-tools-package
Feb 20, 2026
Merged

Move ImageVectortoXml feature into tools package#883
egorikftp merged 1 commit intomainfrom
task/Move-ImageVectortoXml-feature-into-tools-package

Conversation

@egorikftp
Copy link
Member


📝 Changelog

If this PR introduces user-facing changes, please update the relevant Unreleased section in changelogs:

@coderabbitai
Copy link

coderabbitai bot commented Feb 20, 2026

Walkthrough

The pull request restructures the image vector XML conversion feature within the IDE plugin. The feature is being reorganized from the mode.imagevectortoxml package hierarchy to tools.imagevectorxml. Associated screen components, ViewModels, and model classes are being renamed to reflect the new structure, replacing "ImageVectorToXml" naming with "ImageVectorXml". Navigation destinations and their references are updated accordingly. Old classes in the original package location are removed, with equivalent new classes introduced in the new location. The conversion and picker screens maintain their core functionality during the reorganization.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The PR title clearly describes the main change: moving the ImageVectortoXml feature into the tools package, which aligns with the linked issue #868.
Description check ✅ Passed The PR description includes the required changelog checklist template with issue reference (#868), though the checkboxes are not marked as updated.
Linked Issues check ✅ Passed The code changes successfully move ImageVectortoXml from mode package to tools package, updating all package paths, class names, and imports to reflect tools.imagevectorxml organization. All classes are renamed with Xml suffix and reorganized under tools package structure as required by #868.
Out of Scope Changes check ✅ Passed All changes are directly related to the feature relocation and renaming objective. No unrelated modifications or refactoring are present outside the scope of moving ImageVectortoXml into the tools package.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch task/Move-ImageVectortoXml-feature-into-tools-package

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/tools/imagevectorxml/conversion/ImageVectorXmlScreen.kt (1)

63-63: Missed rename: private composable functions still use ImageVectorToXml prefix

ImageVectorToXmlContent (line 115) and ImageVectorToXmlContentPreview (line 148) were not updated as part of this rename sweep, creating an inconsistency with the rest of the file.

♻️ Proposed rename for private functions
-                ImageVectorToXmlContent(
+                ImageVectorXmlContent(
                     state = currentState,
 `@Composable`
-private fun ImageVectorToXmlContent(
+private fun ImageVectorXmlContent(
     state: ImageVectorXmlState.Content,
-private fun ImageVectorToXmlContentPreview() = ProjectPreviewTheme {
-    ImageVectorToXmlContent(
+private fun ImageVectorXmlContentPreview() = ProjectPreviewTheme {
+    ImageVectorXmlContent(

Also applies to: 115-115, 148-148

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In
`@tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/tools/imagevectorxml/conversion/ImageVectorXmlScreen.kt`
at line 63, Private composable names still use the old ImageVectorToXml prefix;
rename the private functions ImageVectorToXmlContent and
ImageVectorToXmlContentPreview to match the file's convention (e.g.,
ImageVectorXmlContent and ImageVectorXmlContentPreview), and update all call
sites including the invocation at ImageVectorToXmlContent in
ImageVectorXmlScreen.kt and the preview usages so they reference the new names.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In
`@tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/tools/imagevectorxml/conversion/ImageVectorXmlScreen.kt`:
- Line 63: Private composable names still use the old ImageVectorToXml prefix;
rename the private functions ImageVectorToXmlContent and
ImageVectorToXmlContentPreview to match the file's convention (e.g.,
ImageVectorXmlContent and ImageVectorXmlContentPreview), and update all call
sites including the invocation at ImageVectorToXmlContent in
ImageVectorXmlScreen.kt and the preview usages so they reference the new names.

@egorikftp egorikftp merged commit cf7e983 into main Feb 20, 2026
4 checks passed
@egorikftp egorikftp deleted the task/Move-ImageVectortoXml-feature-into-tools-package branch February 20, 2026 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move ImageVectortoXml feature into tools package

1 participant