Skip to content

[T3457] FIX: Compute send mode only when a partner has been selected - #2156

Merged
ecino merged 1 commit into
18.0from
T3457-partner-communication-new-button-error-message
Sep 14, 2026
Merged

ecino merged 1 commit into
18.0from
T3457-partner-communication-new-button-error-message

Conversation

@AlexandrePhilibert

Copy link
Copy Markdown

We could not open the partner communications form using the "New" button on the partner communications form. This PR fixes this issue by only computing the send mode once a partner has been selected in the form.

@greptile-apps

greptile-apps Bot commented Sep 14, 2026

Copy link
Copy Markdown

RetriggerConfidence Score: 4/5

Safe to merge: the remaining concern is non-blocking, but a focused regression test should be added.

Findings

  1. P2 Add onchange regression test

Reviews (1) · Last reviewed commit: "[T3457] FIX: Compute send mode only when..."

Comment thread partner_communication/models/communication_job.py
@ecino
ecino merged commit 3ea9292 into 18.0 Sep 14, 2026
2 checks passed
@ecino
ecino deleted the T3457-partner-communication-new-button-error-message branch September 14, 2026 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants