Remove redundant property changed callback#842
Open
yourordinarycat wants to merge 1 commit intoCommunityToolkit:mainfrom
Open
Remove redundant property changed callback#842yourordinarycat wants to merge 1 commit intoCommunityToolkit:mainfrom
yourordinarycat wants to merge 1 commit intoCommunityToolkit:mainfrom
Conversation
This is already covered by the DP registration in the properties file.
Author
|
@dotnet-policy-service agree |
Arlodotexe
requested changes
Apr 10, 2026
Member
There was a problem hiding this comment.
I believe the intent here was to wire up the existing OnOrientationChanged callback, we should do that instead of removing the callback registration.
I see, the difference is that SelectedItem is coming from ListViewBase whereas Orientation is added by Segmented. Nevermind, in that case this can be merged as-is.
Arlodotexe
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
There is a redundant property change callback in the Segmented code. It is already covered by the DP registration so this just removes that line.
PR Type
What kind of change does this PR introduce?
Bugfix
What is the current behavior?
There is a redundant callback installed for the orientation prop, and it's the wrong one.
What is the new behavior?
No redundant callback.
PR Checklist
Please check if your PR fulfills the following requirements:
Other information