Changed Binding to x:Bind in WrapLayoutSample DataTemplates

[Avid29]

Fixes #515

PR Type

What kind of change does this PR introduce?

Bugfix

What is the current behavior?

WrapLayout appear not to load

What is the new behavior?

WrapLayout items appear properly

PR Checklist

Please check if your PR fulfills the following requirements:

• Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
• Based off latest main branch of toolkit
• Tested code with current supported SDKs
• Header has been added to all new source files
• Contains NO breaking changes

Other information

[Arlodotexe]

Looks like the ScrollViewer was removed. ItemsRepeater doesn't have a bullt-in ScrollViewer, we should either add it back or use an ItemsView instead, which uses an ItemsRepeater internally but acts more like a ListView than an ItemsControl.

[Arlodotexe]

I did a bit more digging after @Avid29 pointed out that the ScrollViewer was still present over on Discord:

• Bad news is that this PR from 2023 rolled over the "deliberately avoiding the double-nested ScrollViewer problem" source design and didn't change any of the samples that already had a ScrollViewer, so we've uncovered that for follow-up.
• Good news is that the nested ScrollViewer wasn't the source of the performance issue we were seeing with the WrapLayout sample, so reverting that line range back to include it and move us towards the proper gallery-level fix won't cause new issues between now and then.

Let's add the ScrollViewer back and then close this.

[Jay-o-Way]

If we add a scrollviewer, does that create the possibility people will assume it's part of the control..?

[Arlodotexe]

If we add a scrollviewer, does that create the possibility people will assume it's part of the control..?

@Jay-o-Way Pretty much no, it's part of the sample and not the components source. The scrollview isn't a part of the control to the same extend that the ItemsRepeater isn't a part of the control.

Sample shows off the WrapLayout and example that's easy to copy and get running around the component/control, as with all samples.

[Arlodotexe]

Looks good!