-
Notifications
You must be signed in to change notification settings - Fork 121
[ColorHelper] Add new ColorHelper API #754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Avid29
wants to merge
23
commits into
CommunityToolkit:main
Choose a base branch
from
Avid29:Color-Helper
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r discourage new usage
…were being treated as errors in the CI
…a breaking change betwen ColorHelper.FromHsv and HsvColor.Create
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes CommunityToolkit/Labs-Windows#756
PR Type
What kind of change does this PR introduce?
This PR introduces a new API for the
ColorHelper, though leaves the old API available with no breaking changes (though marked as deprecated)What is the current behavior?
This is the current API
What is the new behavior?
This is the full new API, including the old API marked obsolete.
PR Checklist
Please check if your PR fulfills the following requirements:
By keeping the old fields available and using the new properties to wrap them, breaking changes have been averted. However, the plan would be to removed these deprecated APIs in future versions.
Other information
Note that the
ObsoleteAttributemessages contain a recommendation for how to migrate to the new API. All these migrations have complete behavioral parity, except the fields/properties inHslColorandHsvColorwhich are now clamped to a valid range.