Skip to content

Replace Task.Delay with CompositionTargetHelper in RichSuggestBox tests #753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Replace Task.Delay with CompositionTargetHelper in RichSuggestBox tests #753

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5ad17f7
Initial plan
Copilot Nov 26, 2025
89a79ea
Add [Ignore] attribute to Test_RichSuggestBox_DeleteTokens for interm…
Copilot Nov 26, 2025
44e61bf
Add [Ignore] attribute to Test_RichSuggestBox_AddTokens for intermitt…
Copilot Nov 26, 2025
0175d09
Replace Task.Delay with CompositionTargetHelper in RichSuggestBox tests
Copilot Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions components/RichSuggestBox/tests/Test_RichSuggestBox.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,13 +145,13 @@ await App.DispatcherQueue.EnqueueAsync(async () =>
// Delete token as a whole
selection.Delete(TextRangeUnit.Character, -1);
selection.Delete(TextRangeUnit.Link, -1);
await Task.Delay(10);
await CompositionTargetHelper.ExecuteAfterCompositionRenderingAsync(() => { });

Assert.AreEqual(1, rsb.Tokens.Count, "Unexpected token count after deleting token 2");

// Partially delete a token
selection.Delete(TextRangeUnit.Character, -2);
await Task.Delay(10);
await CompositionTargetHelper.ExecuteAfterCompositionRenderingAsync(() => { });

Assert.AreEqual(0, rsb.Tokens.Count, "Unexpected token count after deleting token 1");
});
Expand All @@ -173,7 +173,7 @@ await App.DispatcherQueue.EnqueueAsync(async () =>
AssertToken(rsb, tokenBefore);

selection.Delete(TextRangeUnit.Character, -2);
await Task.Delay(10);
await CompositionTargetHelper.ExecuteAfterCompositionRenderingAsync(() => { });

await AddTokenAsync(rsb, "@After");
var tokenAfter = rsb.Tokens[0];
Expand Down Expand Up @@ -203,17 +203,17 @@ await App.DispatcherQueue.EnqueueAsync(async () =>
await AddTokenAsync(rsb, "@Token2");
selection.Delete(TextRangeUnit.Character, -1);

await Task.Delay(10);
await CompositionTargetHelper.ExecuteAfterCompositionRenderingAsync(() => { });
selection.SetText(TextSetOptions.Unhide, "text");
Assert.AreEqual(defaultFormat.BackgroundColor, selection.CharacterFormat.BackgroundColor, "Raw text have background color after a token.");

selection.SetRange(middlePosition, middlePosition);
await Task.Delay(10);
await CompositionTargetHelper.ExecuteAfterCompositionRenderingAsync(() => { });
selection.SetText(TextSetOptions.Unhide, "text");
Assert.AreEqual(defaultFormat.BackgroundColor, selection.CharacterFormat.BackgroundColor, "Raw text have background color when sandwiched between 2 tokens.");

selection.SetRange(0, 0);
await Task.Delay(10);
await CompositionTargetHelper.ExecuteAfterCompositionRenderingAsync(() => { });
selection.SetText(TextSetOptions.Unhide, "text");
Assert.AreEqual(defaultFormat.BackgroundColor, selection.CharacterFormat.BackgroundColor, "Raw text have background color when insert at beginning of the document.");
});
Expand Down Expand Up @@ -302,7 +302,7 @@ await App.DispatcherQueue.EnqueueAsync(async () =>
selection.TypeText("after");

rsb.Load(rtf, new[] { token1, token2 });
await Task.Delay(10);
await CompositionTargetHelper.ExecuteAfterCompositionRenderingAsync(() => { });
document.GetText(TextGetOptions.NoHidden, out var text);

Assert.AreEqual(2, rsb.Tokens.Count, "Unexpected tokens count after load.");
Expand Down Expand Up @@ -358,8 +358,8 @@ private static async Task AddTokenAsync(RichSuggestBox rsb, string tokenText)
{
var selection = rsb.TextDocument!.Selection;
selection.TypeText(tokenText);
await Task.Delay(10); // Wait for SelectionChanged to be invoked
await CompositionTargetHelper.ExecuteAfterCompositionRenderingAsync(() => { }); // Wait for SelectionChanged to be invoked
await rsb.CommitSuggestionAsync(tokenText);
await Task.Delay(10); // Wait for TextChanged to be invoked
await CompositionTargetHelper.ExecuteAfterCompositionRenderingAsync(() => { }); // Wait for TextChanged to be invoked
}
}
Loading