Repository navigation
Enable MarkdownTextBlock on Uno Platform 7 - #822
Draft
MartinZikmund wants to merge 5 commits into
Draft
MartinZikmund wants to merge 5 commits into
MartinZikmund wants to merge 5 commits into
Conversation
Points the tooling submodule at the Uno 7 branch and updates global.json (.NET SDK 10.0.401, Uno.Sdk 7.0.0-dev.51, MSBuild.Sdk.Extras 3.0.44). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01E8bkzyS24p8CYDWLUPsaPC
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01E8bkzyS24p8CYDWLUPsaPC
Uno annotates TextPointer.GetPositionAtOffset as nullable, which fails the build with warnings as errors. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01E8bkzyS24p8CYDWLUPsaPC
…is a stub Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01E8bkzyS24p8CYDWLUPsaPC
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01E8bkzyS24p8CYDWLUPsaPC
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enables
MarkdownTextBlockon Uno Platform 7.0 (WinUI 3 flavor):wasm;win32;linux;macos;ios;androidin addition to the existinguwp;wasdk. Uno 7 now ports WinUI'sRichTextBlock, which the control is built on.Changes
chore:toolingsubmodule now points at the Uno 7 tooling branch (MartinZikmund/Tooling-Windows-Submodulemzikmund/uno7-sdk,0686dbc); rootglobal.jsonadopts .NET SDK 10.0.401, Uno.Sdk 7.0.0-dev.51, MSBuild.Sdk.Extras 3.0.44. The.gitmodulesURL still points at upstream.feat:MultiTarget.propsenables the Uno targets; the csprojUsinggroups now also apply to Uno builds (Windows.UI.*for WinUI 2,Microsoft.UI.*for WinUI 3).fix: inline code and task-list checkbox offsets useRenderTransformon Uno, sinceUIElement.Transform3Dis a stub there (inline code rendered raised).fix:TextPointer.GetPositionAtOffsetis annotated nullable in Uno, so thenextlocals inExtensions.csare nowTextPointer?(aCS8600error under warnings-as-errors). Compatible with UWP/WinAppSDK.No
#ifwas needed:DefaultSVGRenderer(SvgImageSource) andImageProvidercompile as-is on Uno 7.Depends on the tooling PR CommunityToolkit/Tooling-Windows-Submodule#317 (the submodule pin is
843a88a, the tooling PR branch head). Until it merges, the submodule SHA only exists on the fork.Validation
dotnet build -f net10.0of the src project: Build succeeded.dotnet pack -p:PackageVersion=0.1.0-local.uno7:CommunityToolkit.Labs.WinUI.Controls.MarkdownTextBlock, haslib/net10.0and depends onUno.WinUI 7.0.0-dev.1656(WinAppSDK TFMs packed as well).net10.0-desktop(Win32/Skia) gallery at 240 DPI. Custom Theme, Full Example (headings, links, italic/bold, block quotes, code, switches) render correctly, including inline code with padding/border and mouse-wheel scrolling.Caveat: building the head locally needed Uno 7 builds of
CommunityToolkit.WinUI.{Converters,Extensions,Helpers,Triggers,Controls.SettingsControls}andUno.Microsoft.Xaml.Behaviors.Interactivity.WinUI(unoplatform/Uno.XamlBehaviors#36); released packages still pull Uno 5.x. The tooling head references them, so CI needs those published first. Not tested: SVG images, wasm/mobile heads, Live Editor tab.🤖 Generated with Claude Code
https://claude.ai/code/session_01E8bkzyS24p8CYDWLUPsaPC