Main Build Failure Cleanup#1296
Open
Omnideth wants to merge 8 commits intoCommunityToolkit:mainfrom
Open
Conversation
… clean again. It required me to break the CPM rule and target various versions - which isn't nice, but also is required since the OpenTelemetry.* packages are at varying numbers. It's possible there is a more elegant way to achieve this, but I wasn't aware of it. If you have dotnet 11 and are not in the dev container, the allowPrerelease will prevent you from building. The only warning is I believe an oustanding issue with .SqlProjects.
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/CommunityToolkit/Aspire/main/eng/scripts/dogfood-pr.sh | bash -s -- 1296Or
iex "& { $(irm https://raw.githubusercontent.com/CommunityToolkit/Aspire/main/eng/scripts/dogfood-pr.ps1) } 1296" |
Contributor
Author
|
I believe these tests are all struggling prior to the build issues completed. I intend to take a look at some of them later to try and clean them up if I can, but let me know if this type of PR would be allowed WITHOUT fixing all the tests first. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to restore a clean build on main by updating central package versions (notably OpenTelemetry) and adding explicit package references to address vulnerability/build failures, plus adjusting devcontainer certificate handling guidance.
Changes:
- Updated OpenTelemetry central versioning and pinned specific instrumentation package versions in central package management.
- Added explicit package references in specific integrations (PowerShell, KurrentDB) and centrally pinned
System.Security.Cryptography.Xmlto address restore/audit failures. - Updated devcontainer configuration and docs around dev-certs, including adding a devcontainer lock file.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/CommunityToolkit.Aspire.Hosting.PowerShell/CommunityToolkit.Aspire.Hosting.PowerShell.csproj | Adds explicit references (OTel + System.Security.Cryptography.Xml) to influence resolved dependency versions. |
| src/CommunityToolkit.Aspire.Hosting.KurrentDB/CommunityToolkit.Aspire.Hosting.KurrentDB.csproj | Adds OpenTelemetry.Api reference to influence resolved dependency versions. |
| docs/setup.md | Adds a devcontainer note about dev-certs tooling. |
| Directory.Packages.props | Pins OTel instrumentation versions and adds System.Security.Cryptography.Xml to central versions. |
| Directory.Build.props | Bumps OpenTelemetryVersion property. |
| .gitignore | Ignores *.lscache. |
| .devcontainer/post-create.sh | Removes dotnet dev-certs auto-trust logic in favor of external tooling. |
| .devcontainer/devcontainer.json | Adds devcontainer-dev-certs feature. |
| .devcontainer/devcontainer-lock.json | Introduces a devcontainer features lock file. |
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Reduce test failures
…sed by the Copilot review of the initial PR.
Contributor
Author
|
Worked with @afscrome to combo his test cleanup with my main build cleanup. I addressed the copilot issues. Requesting formal review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
**Closes #1287 **
Technically this doesn't have an issue yet, I intend to make it a WIP PR before asking for review, but I did double dip with the Powershell PR I made, and will close out, so I'll use that issue as the Issue Number.
This PR is an attempt to try and get main clean again.
It required me to break the CPM rule and target various versions - which isn't nice, but also is required since the OpenTelemetry.* packages are at varying numbers.
It's possible there is a more elegant way to achieve this, but I wasn't aware of it.
If you have dotnet 11 and are not in the dev container, the allowPrerelease will prevent you from building.
The only warning is I believe an oustanding issue with .SqlProjects.
PR Checklist
Will make this a working PR, and edit as we go.
Other information
The intent is to try and get main and the ci/cd stable enough to full clear a build.