Fixing build from a package with security issue#1157
Merged
aaronpowell merged 1 commit intomainfrom Mar 13, 2026
Merged
Conversation
…osoft.Bcl.Memory because it had a security issue
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/CommunityToolkit/Aspire/main/eng/scripts/dogfood-pr.sh | bash -s -- 1157Or
iex "& { $(irm https://raw.githubusercontent.com/CommunityToolkit/Aspire/main/eng/scripts/dogfood-pr.ps1) } 1157" |
aaronpowell
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Meilisearch integration’s NuGet dependencies to a newer MeiliSearch client version and adds an explicit Microsoft.Bcl.Memory dependency/version pin to ensure consistent restores/builds across the Meilisearch packages.
Changes:
- Bump central
MeiliSearchpackage version from0.17.1to0.18.0. - Add
Microsoft.Bcl.Memoryas a direct dependency to both Meilisearch projects. - Pin
Microsoft.Bcl.Memoryversion centrally inDirectory.Packages.props.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/CommunityToolkit.Aspire.Meilisearch/CommunityToolkit.Aspire.Meilisearch.csproj | Adds Microsoft.Bcl.Memory PackageReference to the Meilisearch client integration package. |
| src/CommunityToolkit.Aspire.Hosting.Meilisearch/CommunityToolkit.Aspire.Hosting.Meilisearch.csproj | Adds Microsoft.Bcl.Memory PackageReference to the hosting integration package. |
| Directory.Packages.props | Central version bump for MeiliSearch and adds a central version entry for Microsoft.Bcl.Memory. |
You can also share your feedback on Copilot code review. Take the survey.
| <PackageReference Include="Microsoft.Extensions.Hosting.Abstractions" /> | ||
| <PackageReference Include="Microsoft.Extensions.Configuration.Binder" /> | ||
| <PackageReference Include="OpenTelemetry.Extensions.Hosting" /> | ||
| <PackageReference Include="Microsoft.Bcl.Memory" /> |
| <ItemGroup> | ||
| <PackageReference Include="Aspire.Hosting" /> | ||
| <PackageReference Include="MeiliSearch" /> | ||
| <PackageReference Include="Microsoft.Bcl.Memory" /> |
Comment on lines
129
to
+130
| </ItemGroup> | ||
| <ItemGroup Label="Overrides"> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.