Skip to content

Strip all leading system-reminder wrappers in conversation view #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
FantWu2024 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Strip all leading system-reminder wrappers in conversation view #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions frontend/dashboard/src/components/conversation/MessageBubble.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,15 +92,13 @@ export default function MessageBubble({

function UserBubble({ message }: { message: ConversationMessage }) {
const [showWrapper, setShowWrapper] = useState(false);
const hasWrapper = SYSTEM_REMINDER_PATTERN.test(message.text);
let displayText = message.text;
let wrapperText = "";
if (hasWrapper) {
const m = message.text.match(/^([\s\S]*?<\/(system-reminder|command-name|local-command-stdout|command-message|command-args)>\s*)/i);
if (m) {
wrapperText = m[1];
displayText = message.text.slice(m[1].length);
}
while (SYSTEM_REMINDER_PATTERN.test(displayText)) {
const m = displayText.match(/^([\s\S]*?<\/(system-reminder|command-name|local-command-stdout|command-message|command-args)>\s*)/i);
if (!m) break;
wrapperText += m[1];
displayText = displayText.slice(m[1].length);
}

return (
Expand Down
12 changes: 5 additions & 7 deletions frontend/dashboard/src/components/conversation/TerminalView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,17 +88,15 @@ function ContinuationRow({ children }: { children: ReactNode }) {

function UserRow({ message }: { message: ConversationMessage }) {
const [showWrapper, setShowWrapper] = useState(false);
const hasWrapper = SYSTEM_REMINDER_PATTERN.test(message.text);
let displayText = message.text;
let wrapperText = "";
if (hasWrapper) {
const m = message.text.match(
while (SYSTEM_REMINDER_PATTERN.test(displayText)) {
const m = displayText.match(
/^([\s\S]*?<\/(system-reminder|command-name|local-command-stdout|command-message|command-args)>\s*)/i,
);
if (m) {
wrapperText = m[1];
displayText = message.text.slice(m[1].length);
}
if (!m) break;
wrapperText += m[1];
displayText = displayText.slice(m[1].length);
}
return (
<div className="mt-4 flex gap-2 rounded-compact bg-n-surface px-2 py-1">
Expand Down