Conversation
nstepien
commented
Feb 26, 2026
| export async function scrollGrid(options: ScrollToOptions) { | ||
| page.getGrid().element().scroll(options); | ||
| // let the browser fire the 'scroll' event | ||
| await new Promise(requestAnimationFrame); |
Collaborator
Author
There was a problem hiding this comment.
Some tests were flaky after scrollGrid(), hopefully this will resolve it.
The scrollend isn't fired when the element isn't scrolled though, but in that case the test will timeout and we'll know why, so we won't unintentionally add useless scrollGrid() calls.
Collaborator
There was a problem hiding this comment.
https://playwright.dev/docs/input#scrolling
Do you think we should try
await page.getByTestId('scrolling-container').evaluate(e => e.scrollTop += 100);
Collaborator
Author
There was a problem hiding this comment.
Vitest doesn't expose evaluate, probably because tests run in the browser context, rather than in a nodejs context
amanmahajan7
approved these changes
Feb 26, 2026
| export async function scrollGrid(options: ScrollToOptions) { | ||
| page.getGrid().element().scroll(options); | ||
| // let the browser fire the 'scroll' event | ||
| await new Promise(requestAnimationFrame); |
Collaborator
There was a problem hiding this comment.
https://playwright.dev/docs/input#scrolling
Do you think we should try
await page.getByTestId('scrolling-container').evaluate(e => e.scrollTop += 100);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream bug: microsoft/playwright#39268
Looks like they're petrified by a thorough bug report.