Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds optional TLS/SSL configuration for MariaDB/MySQL connections in the Docker iTop environment, wiring certificate mounts into the DB/client containers and documenting how to enable secure transport.
Changes:
- Add database TLS configuration (cert paths, TLS versions/ciphers,
require_secure_transport) for MySQL/MariaDB. - Mount DB/webserver certificate directories into services (PHP, DBs, Adminer) and add a PHP client config (
client.cnf). - Extend documentation to describe TLS enablement and Adminer SSL usage.
Reviewed changes
Copilot reviewed 16 out of 19 changed files in this pull request and generated 18 comments.
Show a summary per file
| File | Description |
|---|---|
| readme.md | Updates container descriptions and mentions DB TLS/cert availability. |
| docker-compose.yml | Mounts certs into PHP/DB/Adminer and adds Adminer SSL env vars/plugins mount. |
| build/default_configuration/php/client.cnf | Adds MySQL/MariaDB client TLS configuration. |
| build/default_configuration/mysql/my.cnf | Adds MySQL server TLS settings and require_secure_transport. |
| build/default_configuration/mariadb/my.cnf | Adds MariaDB server TLS settings and require_secure_transport. |
| build/default_configuration/certs/webserver/certificate.key | Adds bundled webserver private key (sensitive). |
| build/default_configuration/certs/webserver/certificate.crt | Adds bundled webserver certificate. |
| build/default_configuration/certs/database/* | Adds CA/client/server certs and private keys for DB TLS. |
| build/default_configuration/adminer/plugins-enabled/enable-ssl;php.php | Adds Adminer plugin to enable SSL connections. |
| addons/documentation/how_to.md | Adds/updates TLS and dump import/export guidance. |
| addons/docker_scripts/down_and_up.sh | Adds helper script to restart compose with .env.local. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Molkobain
reviewed
May 4, 2026
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Molkobain
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Base information
Symptom (bug) / Objective (enhancement)
Add configuration for secured connection between database server and client