N°9519 - Add proxy to Webhook Request#29
Open
ozan-cristan wants to merge 1 commit intoCombodo:masterfrom
Open
Conversation
github-project-automation
Bot
moved this to First review needed
in Combodo PRs dashboard
Author
|
Hi, I have uploaded the pull request with the proposed changes related to proxy support. PR: #29 Please let me know if you would like me to add more details or make any adjustments. Best regards, |
Hipska
suggested changes
Mar 13, 2026
Collaborator
There was a problem hiding this comment.
Quick remark, please make the code comments in English so everyone can understand them.
Also, be aware that your changes make that these proxy settings are now applied by default for all new users!
And I guess the people from Combodo will require you to fill in the request template, You seem to have removed it all (in your initial post)
jf-cbd
moved this from First review needed
to Pending technical review
in Combodo PRs dashboard
jf-cbd
moved this from Pending technical review
to Pending review
in Combodo PRs dashboard
Member
|
Hello, thank you for your PR ! We'll review your code in sprint 3.4, that should start at the end of summer (from September). |
jf-cbd
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Symptom (bug) / Objective (enhancement)
In many enterprise environments, iTop servers do not have direct access to the Internet and must route all outbound HTTP/HTTPS traffic through a corporate proxy.
Currently, the webhook integration module does not provide any way to configure a proxy for outbound requests.
As a result, webhook calls fail in restricted networks, usually with DNS resolution or connection errors, making integrations with external services (Telegram, Slack, APIs, etc.) unusable.
The objective of this enhancement is to allow webhook HTTP requests to be routed through a configurable proxy, making the webhook integration usable in secured and restricted infrastructures.
Reproduction procedure (bug)
(Not applicable, this is an enhancement and not a bug.)
Cause (bug)
(Not applicable, this is an enhancement and not a bug.)
Proposed solution (bug and enhancement)
The solution adds optional HTTP proxy support to the webhook request sender:
The proxy configuration is read from the module settings:
host(mandatory)user(optional)password(optional)When a proxy is defined, the corresponding CURL options are injected into the request:
CURLOPT_PROXYCURLOPT_PROXYTYPECURLOPT_PROXYUSERPWD(if authentication is configured)When no proxy is defined, the behavior remains unchanged, ensuring full backward compatibility.
This allows webhook integrations to work transparently in environments where Internet access is only available through a proxy.
The change is limited to the webhook integration module and does not impact any other part of iTop.