Skip to content

fix(node): keep odd versions Current through maintenance window #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CalvinAllen merged 1 commit into from
Apr 20, 2026
Merged

fix(node): keep odd versions Current through maintenance window #242

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/runtimes/node/lifecycle.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,8 +91,10 @@ func (lp *lifecycleProvider) resolve(e scheduleEntry) string {
if e.LTS != "" {
return string(lifecycle.MaintenanceLTS)
}
// Odd releases enter "maintenance" before EOL but are not LTS.
return string(lifecycle.EOL)
// Odd releases have a maintenance window before EOL but are not LTS;
// keep them labeled Current until their end date so the display
// matches nodejs.org's release schedule page.
return string(lifecycle.Current)
}

if lts := parseDate(e.LTS); !lts.IsZero() && !today.Before(lts) {
Expand Down
13 changes: 11 additions & 2 deletions src/runtimes/node/lifecycle_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,17 +55,26 @@ func TestLifecycleProvider_VersionStatus(t *testing.T) {
want: string(lifecycle.Current),
},
{
name: "v23 odd version in maintenance is EOL (not LTS)",
name: "v23 odd version in maintenance window is still Current (not LTS)",
now: "2025-04-15",
version: "23.5.0",
want: string(lifecycle.EOL),
want: string(lifecycle.Current),
},
{
name: "v23 after end is EOL",
now: "2025-07-01",
version: "23.5.0",
want: string(lifecycle.EOL),
},
// v25: start 2025-10-15, maintenance 2026-04-01, end 2026-06-01 (no LTS)
// Regression for #241: odd version past maintenance but before end
// should show as Current, not EOL.
{
name: "v25 past maintenance but before end is Current",
now: "2026-04-20",
version: "25.9.0",
want: string(lifecycle.Current),
},
// Edge cases
{
name: "unknown major returns empty",
Expand Down
Loading