Decouple native ILP backend execution from registered pipelines - #1147
Open
isPANN wants to merge 5 commits into
Open
Decouple native ILP backend execution from registered pipelines#1147isPANN wants to merge 5 commits into
isPANN wants to merge 5 commits into
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1147 +/- ##
==========================================
+ Coverage 95.93% 95.96% +0.02%
==========================================
Files 1074 1076 +2
Lines 132106 132337 +231
==========================================
+ Hits 126730 126991 +261
+ Misses 5376 5346 -30 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integer ILP solving currently passes through a registered integer-to-float coefficient reduction before reaching HiGHS. This refactor moves backend encoding, execution, decoding, and original-ILP validation into an internal
HighsAdapterthat accepts nativeILP<V, C>values. Registry lookup, type-erased terminal dispatch, and source-solution extraction stay in orchestration.All 155 registered source variants retain their ILP solving pipelines: 147 integer pipelines now stop at their original integer ILP, and eight native float pipelines retain their routes. The adapter supports all four bool/i64-variable and i64/f64-coefficient combinations, reuses the existing
good_lpbackend and numeric transport policy, and builds expressions without per-term temporary allocations.The public
ILPSolver::solvesignature, configuration fields, error variants, and CLI/JSON/MCP result formats are preserved. Reported reduction paths now end at native ILPs. Integer coefficient transport failures use the existingInexactTransporterror at the adapter boundary; assignments violating the original integer ILP useInvalidSolutioninstead of failing later during coefficient-cast extraction. Existing explicit coefficient-conversion reductions remain available.Validation:
make checkpasses after the final cleanup: formatting, clippy, and full workspace tests.make mcp-testandmake paperpassed during implementation.