-
Notifications
You must be signed in to change notification settings - Fork 0
fix(audit): resolve linting and syntax issues, update actions #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,82 @@ | ||
| #requires -Modules Pester | ||
|
|
||
| # Unit tests for the pure/deterministic helper functions in | ||
| # scripts/lib/Autopilot.Common.psm1. These functions build gh payloads, | ||
| # normalise repo names, and parse tool output — the highest-value logic to | ||
| # pin down because the operator mutates OTHER repos based on their results. | ||
|
|
||
| BeforeAll { | ||
| $script:RepoRoot = Split-Path -Parent $PSScriptRoot | ||
| $script:ModulePath = Join-Path $RepoRoot "scripts/lib/Autopilot.Common.psm1" | ||
| Import-Module $ModulePath -Force | ||
| } | ||
|
|
||
| AfterAll { | ||
| Remove-Module Autopilot.Common -Force -ErrorAction SilentlyContinue | ||
| } | ||
|
|
||
| Describe "Get-RepoName" { | ||
| It "extracts owner/repo from an https clone URL" { | ||
| Get-RepoName -RepoUrl "https://github.com/acme/widgets" | Should -Be "acme/widgets" | ||
| } | ||
|
|
||
| It "tolerates a trailing slash" { | ||
| Get-RepoName -RepoUrl "https://github.com/acme/widgets/" | Should -Be "acme/widgets" | ||
| } | ||
|
|
||
| It "handles an ssh-style URL by taking the final two path segments" { | ||
| Get-RepoName -RepoUrl "https://github.com/acme/deep/nested/widgets" | Should -Be "nested/widgets" | ||
| } | ||
| } | ||
|
|
||
| Describe "Invoke-GhJson" { | ||
| Context "when gh returns clean JSON" { | ||
| BeforeEach { | ||
| Mock -CommandName gh -ModuleName Autopilot.Common -MockWith { '{"login":"octocat","type":"User"}' } | ||
| } | ||
|
|
||
| It "parses a JSON object into a PSCustomObject" { | ||
| $result = Invoke-GhJson -Arguments @("api", "user") | ||
| $result.login | Should -Be "octocat" | ||
| $result.type | Should -Be "User" | ||
| } | ||
| } | ||
|
|
||
| Context "when gh emits a leading warning line before the JSON" { | ||
| BeforeEach { | ||
| # gh sometimes prints noise on stdout before the payload; the | ||
| # function must locate the first { or [ and parse from there. | ||
| Mock -CommandName gh -ModuleName Autopilot.Common -MockWith { "Warning: something`n[{""number"":7}]" } | ||
| } | ||
|
|
||
| It "strips the prefix and parses the array" { | ||
| $result = Invoke-GhJson -Arguments @("api", "issues") | ||
| $result[0].number | Should -Be 7 | ||
| } | ||
| } | ||
|
|
||
| Context "when gh returns nothing" { | ||
| BeforeEach { | ||
| Mock -CommandName gh -ModuleName Autopilot.Common -MockWith { $null } | ||
| } | ||
|
|
||
| It "returns null without throwing" { | ||
| Invoke-GhJson -Arguments @("api", "nothing") | Should -BeNullOrEmpty | ||
| } | ||
| } | ||
| } | ||
|
|
||
| Describe "Get-LogTail" { | ||
| It "returns null when the log file does not exist" { | ||
| Get-LogTail -LogPath (Join-Path $TestDrive "missing.log") -Lines 5 | Should -BeNullOrEmpty | ||
| } | ||
|
|
||
| It "returns only the last N lines of an existing log" { | ||
| $log = Join-Path $TestDrive "sample.log" | ||
| 1..10 | ForEach-Object { "line $_" } | Set-Content -Path $log | ||
| $tail = Get-LogTail -LogPath $log -Lines 3 | ||
| $tail | Should -HaveCount 3 | ||
| $tail[-1] | Should -Be "line 10" | ||
| $tail[0] | Should -Be "line 8" | ||
| } | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The operator still calls these helpers with
-Args(for exampleInvoke-Checked -Command "codex" -Args ...), but this rename removes theArgsparameter;-Argsis not a valid abbreviation of-Arguments, so non-dry-run processing fails with “parameter cannot be found” before Codex or verification can run. Either keep anArgsparameter/alias or update every call site to use-Arguments.Useful? React with 👍 / 👎.