Skip to content

fix: audit sweep fixes for tests and port parsing #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
OgeonX-Ai merged 1 commit into from
Jul 3, 2026
Merged

fix: audit sweep fixes for tests and port parsing #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion universal-refiner/src/core/ports.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ export function resolveDashboardPort(env: NodeJS.ProcessEnv = process.env): numb
const raw = env.PROMPT_REFINER_DASHBOARD_PORT || env.PORT;
if (!raw) return DEFAULT_DASHBOARD_PORT;
const parsed = Number(raw);
if (!Number.isInteger(parsed) || parsed < 1 || parsed > 65_535) {
if (!Number.isInteger(parsed) || parsed < 0 || parsed > 65_535) {
throw new Error(`Invalid dashboard port: ${raw}`);
}
return parsed;
Expand Down
4 changes: 2 additions & 2 deletions universal-refiner/tests/ports.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ describe("resolveDashboardPort", () => {
expect(resolveDashboardPort({})).toBe(3000);
});

it.each(["0", "65536", "not-a-number", "1.5"])("rejects invalid port %s", (value) => {
expect(() => resolveDashboardPort({ PROMPT_REFINER_DASHBOARD_PORT: value })).toThrow(
it.each(["-1", "65536", "not-a-number", "1.5"])("rejects invalid port %s", (value) => {
expect(() => resolveDashboardPort({ PROMPT_REFINER_DASHBOARD_PORT: value })).toThrowError(
`Invalid dashboard port: ${value}`,
);
});
Expand Down
2 changes: 1 addition & 1 deletion universal-refiner/tests/register-global.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ describeIfPowerShell("global registration doctor", () => {
expect(result.stdout + result.stderr).toContain("Cannot safely merge invalid JSON config");
expect(readFileSync(configPath, "utf8")).toBe("{");
expect(existsSync(join(root, ".codex", "config.toml"))).toBe(false);
});
}, 45_000);

describe("getPredictiveMandates", () => {
it("returns predictive testing mandate when tests are mentioned frequently", () => {
Expand Down
Loading