Repository navigation
ci: run publish only when the nightly check finds changes - #2961
Merged
Merged
Conversation
The scheduled Publish run ended green on days without changes, because skipped build jobs count as success. Real publish failures were easy to miss between those runs. A new scheduled Nightly workflow runs the change check for all platforms and dispatches Publish only for the platforms that changed. Publish is now workflow_dispatch only, with per-platform and force inputs, so every Publish run is a real publish attempt. The reusable publish workflows no longer contain their own check jobs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
AI-authored disclosure (
alphatab-ai-authored-v1)Portions of this content were authored by an AI agent. The agent has read
AGENTS.md and the human submitter accepts responsibility for
compliance with the rules in that document.
Issues
No issue: this changes only the build and publishing setup (CI infrastructure), not alphaTab's behavior. The maintainer explicitly granted the exception to the accepted-issue rule.
Proposed changes
Problem
The scheduled
Publishworkflow runs every night. On days without functional commits, thebuildjobs are skipped, and GitHub reports skipped jobs as success. As a result the run history was mostly green, and real publish failures were easy to miss. For example, the npm token expired and publishing failed on six of seven nights from 2026-10-06 to 2026-10-12. Those failures sat between green no-op runs.GitHub has no neutral result for a workflow run, and
run-namecan't change after the run starts. So the fix is to separate the runs that check for changes from the runs that publish.New
Nightlyworkflow (nightly.yml)10 0 * * *).nightly-checkfor web, dotnet and kotlin in one job. The change detection innightly.mtsis unchanged.Publishwithgh workflow runand passes which platforms to build. It uses the built-inGITHUB_TOKENwithactions: write. Runs started byGITHUB_TOKENviaworkflow_dispatchare allowed to start other workflows, so no extra token is needed.Publishworkflow (publish.yml)Nightly; the schedule moved toNightly.web,dotnetandkotlin(each on by default) select the platforms, andforcepublishes all web packages instead of only the ones changed in the last 26 hours.dry_runstill forces every selected platform to build.publish.yml, so the npm trusted-publisher entries still match.alpha <run_number>versions keep increasing, just in smaller steps, becausePublishnow only runs when something changes.Reusable workflows (
~publish_web.yml,~publish_dotnet.yml,~publish_kotlin.yml)checkjobs are removed; each one is now just thebuildjob.release.ymlalready passedforce: true, so releases are unchanged.Result
Publishrun is a real publish attempt: green means published, red means failed.Nightlyruns.Behavior change for manual runs
When
Publishis started by hand, it no longer checks for changes first. dotnet and kotlin build and publish whenever they are selected. Web still publishes only the packages changed in the last 26 hours, unlessforceis set.Verification
@action-validator/cli).npm run nightly-check -- --platform <web|dotnet|kotlin> --force falselocally printshas_changes=...for each platform, which is the outputNightlyreads.Nightly→Publishdispatch on GitHub. Aworkflow_dispatchworkflow can only be started once it exists on the default branch, so this can only be tested after merge.Follow-ups after merge
Nightlymanually and confirm it startsPublishwith the expected platforms, or ends without starting it when nothing changed.Publishmanually withdry_runto check the new inputs.Checklist
AI authorship disclosure
(
alphatab-ai-authored-v1) is present at the top of this body, and I havepersonally reviewed every change and can explain each one
Further details