Release - #1152
Merged
Merged
Release#1152
Conversation
Bumps [enshrined/svg-sanitize](https://github.com/darylldoyle/svg-sanitizer) from 0.22.0 to 1.0.0. - [Release notes](https://github.com/darylldoyle/svg-sanitizer/releases) - [Changelog](https://github.com/darylldoyle/svg-sanitizer/blob/master/CHANGELOG.md) - [Commits](darylldoyle/svg-sanitizer@0.22.0...1.0.0) --- updated-dependencies: - dependency-name: enshrined/svg-sanitize dependency-version: 1.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Collaborator
Author
Bumps [codeinwp/themeisle-sdk](https://github.com/Codeinwp/themeisle-sdk) from 3.3.61 to 3.3.62. - [Release notes](https://github.com/Codeinwp/themeisle-sdk/releases) - [Changelog](https://github.com/Codeinwp/themeisle-sdk/blob/v3.3.62/CHANGELOG.md) - [Commits](Codeinwp/themeisle-sdk@v3.3.61...v3.3.62) --- updated-dependencies: - dependency-name: codeinwp/themeisle-sdk dependency-version: 3.3.62 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
) Groovy Menu's auto-integration grabs the top output buffer at shutdown priority 0. Since 4.2.12 our capture at PHP_INT_MIN leaves it an empty re-armed buffer, so the menu markup was dropped. Apply its final-output filter to the captured page before image replacement and take over its shutdown step only when our capture runs. Fixes #1149 Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
Since 4.2.12 close_buffer() re-armed an empty capture buffer and force-flushed buffers stacked above ours at shutdown PHP_INT_MIN. Code that opens a buffer early and reads it back with ob_get_clean() on shutdown priority 0 (FacetWP refresh, Groovy Menu) received an empty string. - Stop re-arming a buffer after the capture, so a buffer opened before ours is on top again and holds the processed page. - When third-party buffers sit above ours, defer the capture until the priority 0 shutdown callbacks ran instead of force-flushing them. - Guard the Groovy Menu compatibility against a double menu insertion when its own shutdown step runs before the deferred capture. Fixes #1156 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This reverts commit ca34eb5.
The shutdown capture added in 4.2.12 flushes the buffers stacked above ours and opens a new buffer afterwards. Code that opens a buffer early and reads it back with ob_get_clean() on shutdown priority 0 (FacetWP refresh, Groovy Menu) received an empty string. Restore the 4.2.11 in-handler processing as the default and keep the shutdown capture as an opt-in through optml_capture_at_shutdown. An exception thrown during the replacement still never breaks the page. Fixes #1156 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…uffers Fix FacetWP refresh and other shutdown buffer readers: process in the output handler by default again
Collaborator
Author
|
🎉 This PR is included in version 4.2.14 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
pirate-bot
added
the
released
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issues
This release will close the following issues once merged:
strpos()TypeError #1147Public changelog