You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Color palette as CSS variables logs wp.components.Theme warnings in the Site Editor #32
The theme's colour palette is defined as CSS variables, which the Site Editor's own colour handling can't read. Every time the Site Editor opens, the browser console shows three warnings:
wp.components.Theme: "var(--nv-text-color, #202020)" is not a valid color value for the 'accent' prop.
wp.components.Theme: "var(--nv-site-bg, #FFFFFF)" is not a valid color value for the 'background' prop.
wp.components.Theme: The background color ("var(--nv-site-bg, #FFFFFF)") does not have sufficient contrast against the accent color ("var(--nv-text-color, #202020)").
Every entry of theme.jsonsettings.color.palette is a var(--nv-…, #hex) value, so that a site coming from Neve inherits Neve's colours (ti-bg is var(--nv-site-bg, #FFFFFF), ti-fg is var(--nv-text-color, #202020), and so on). The Site Editor passes the palette's background and foreground to wp.components.Theme, which expects literal colours. So it can't compute the canvas UI's colours or the contrast check from them.
Step-by-step reproduction instructions
With Eduacademy 1.0.1 active and SCRIPT_DEBUG on, go to Appearance → Editor.
Open the browser console.
Expected: no warnings from the theme's palette. Actual: the three wp.components.Theme warnings above, on every Site Editor load, and on every template or part opened in it.
Screenshots, screen recording, code snippet or Help Scout ticket
Possible fix: keep literal hex values in theme.json's palette, and apply the Neve overrides through the inherited inline CSS that Assets_Manager already prints (overriding the --wp--preset--color--ti-* variables there). The palette entries would then be real colours, while a site coming from Neve still gets Neve's colours.
Found while adding Eduacademy to the WordPress compatibility checks (Codeinwp/qa-compatibility#168). Seen on WordPress 7.0.9, 7.1-RC1 and 7.1.5 alike.
Environment info
Eduacademy 1.0.1 (built from the v1.0.1 tag), WordPress 7.0.9 / 7.1-RC1 / 7.1.5, PHP 8.3, SCRIPT_DEBUG on, Chromium.
Activity