You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Patterns content-1 and features-2 request missing media 108–110 (404s in the editor) #30
Two of the theme's patterns point at images by attachment ID from the site they were made on. On any other site those attachments don't exist, so whenever the editor shows these patterns it asks for them and gets 404 (Not Found) in the browser console. That happens in the Site Editor (the Front Page template uses content-1), in the block inserter's previews, and in the editor.
inc/patterns/layout/content-1.php: three Cover blocks with "id":108 (line 62), "id":109 (line 74) and "id":110 (line 120). Their url already comes from Assets_Manager::get_image_url(); only the IDs are left over.
inc/patterns/layout/features-2.php: two Image blocks with "id":108 (line 56) and "id":109 (line 70).
The images themselves display, because the URLs point at the theme's own assets/img/ files. But the IDs trigger the failed requests on every site, and on a site that does have attachments 108–110 they would point the blocks at unrelated media from that site's library.
Related: #3, where content-1's images were being wired to Assets_Manager::get_image_url.
Step-by-step reproduction instructions
On any site with Eduacademy 1.0.1 active, open the browser's developer tools (Console and Network tabs).
Go to Appearance → Editor → Templates → Front Page.
Watch the Network tab.
Expected: no failed requests. Actual:GET /wp-json/wp/v2/media/108, /109 and /110 answer 404, and the console shows three "Failed to load resource" errors. The same happens when inserting the patterns from Patterns → Eduacademy Patterns.
Screenshots, screen recording, code snippet or Help Scout ticket
Fix suggestion: drop the "id" attribute (and the matching wp-image-<id> class on Image blocks, if present) from these five blocks, so they keep only the theme-asset URL.
Found while adding Eduacademy to the WordPress compatibility checks (Codeinwp/qa-compatibility#168). The same happens on every WordPress version tried (7.0.9, 7.1-RC1, 7.1.5).
Environment info
Eduacademy 1.0.1 (built from the v1.0.1 tag), WordPress 7.0.9 / 7.1-RC1 / 7.1.5, PHP 8.3, Chromium.
Activity