You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Neve heading typography (H1–H6 weight, size, line height) never carries over to Eduacademy #29
When a site switches from Neve to Eduacademy, Neve's heading typography (H1–H6 weight, size and line height) never carries over. Only the body typography does. Eduacademy's theme.json reads --neve-font-weight-h1, --neve-font-size-h2 and so on, but the theme never prints those variables, so headings always use Eduacademy's defaults.
There are two separate mistakes, and both would need fixing:
inc/Assets_Manager.php line 190 builds the section name with a trailing underscore ('h1_'…'h6_') and passes it to Neve_Mods::get_neve_typeface_general(). That method only accepts names from AVAILABLE_TYPEFACE_CONTROLS ('', 'h1'…'h6', inc/Neve_Mods.php line 34), so in_array() (line 178) refuses every heading and returns an empty array.
Even when called with 'h1', the method reads 'neve_' . $type_setting_name . 'typeface_general' (line 181), which is neve_h1typeface_general. Neve stores the setting as neve_h1_typeface_general (MODS_TYPEFACE_H1 in Neve's inc/core/settings/config.php), so it would still find nothing.
The body works only because its section name is the empty string: that gives neve_typeface_general, which is Neve's real key.
Step-by-step reproduction instructions
On a site with Neve active, go to Appearance → Customize → Typography → Headings → H1. Set the weight to 800 and the size to 44px. Publish.
Switch the theme to Eduacademy 1.0.1.
Open any page and view the page source. Find the theme's inline style (eduacademy-style-inline-css).
Expected: the inline :root{…} block contains --neve-font-weight-h1:800, --neve-font-size-h1:44px and the heading variables, and an H1 renders at weight 800 and 44px. Actual: no --neve-font-*-h1 (or any H2–H6) variable is printed, and the H1 keeps Eduacademy's default weight (600) and size.
Without Neve installed, the same result comes from setting the option directly:
Screenshots, screen recording, code snippet or Help Scout ticket
Found while adding Eduacademy to the WordPress compatibility checks (Codeinwp/qa-compatibility#168). The new test in tests/test-assets-manager.php (#26) covers a body font weight, which is the one typography value that does carry over, so it passes. The same happens on every WordPress version tried (7.0.9, 7.1-RC1, 7.1.5).
Environment info
Eduacademy 1.0.1 (built from the v1.0.1 tag), WordPress 7.0.9 / 7.1-RC1 / 7.1.5, PHP 8.3, wp-env.
Activity