You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Heading font set in Neve is replaced by the body font after switching to Eduacademy #28
When a site switches from Neve to Eduacademy, Eduacademy is meant to keep Neve's fonts. The body font carries over, but the heading font doesn't: headings use the body font instead of the heading font chosen in Neve.
In inc/Assets_Manager.php, get_css_font_vars() reads Neve's heading font (line 174). Then, when a body font is set, it overwrites that value with the body font (line 179):
$neve_headings_font = $neve_body_font; // If the body font is set, the headings font should be the same until we check if the headings font is set.
The check that follows reads that overwritten variable, so the heading font Neve stored is never used. The comment describes the intent (body font as a fallback), but the code replaces the stored value rather than falling back to it.
Step-by-step reproduction instructions
On a site with Neve active, go to Appearance → Customize → Typography. Set the body font to Outfit and the headings font to Fraunces (both are in Eduacademy's font list). Publish.
Switch the theme to Eduacademy 1.0.1.
Open any page and view the page source. Find the theme's inline style (eduacademy-style-inline-css).
Expected:--neve-font-family-body:Outfit;--neve-font-family-heading:Fraunces, with headings rendered in Fraunces. Actual:--neve-font-family-body:Outfit;--neve-font-family-heading:Outfit, with headings rendered in Outfit.
Without Neve installed, the same result comes from setting the option directly:
Screenshots, screen recording, code snippet or Help Scout ticket
Found while adding Eduacademy to the WordPress compatibility checks (Codeinwp/qa-compatibility#168). The output above was read on a seeded test site with wp eval 'echo Eduacademy\Assets_Manager::get_inherited_style_values();'. The same happens on every WordPress version tried (7.0.9, 7.1-RC1, 7.1.5), so it is not a WordPress compatibility problem.
Environment info
Eduacademy 1.0.1 (built from the v1.0.1 tag), WordPress 7.0.9 / 7.1-RC1 / 7.1.5, PHP 8.3, wp-env.
Activity