Fix restoring native resolution from DSR modes - #208
Open
bbj233 wants to merge 1 commit into
Open
Conversation
✅ Deploy Preview for codectory ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
AI disclosure: This fix was diagnosed and implemented with assistance from OpenAI Codex (GPT-5.6 Sol). The user supplied the problem report and manually validated the fix in the affected game.
Summary
DM_DISPLAYFIXEDOUTPUTwhen changing resolutionDEVMODEfieldsChangeDisplaySettingsExcalls instead of silently continuingProblem
When switching from an NVIDIA DSR/DLDSR resolution back to the native resolution,
EnumDisplaySettings(ENUM_CURRENT_SETTINGS)may returnDM_DISPLAYFIXEDOUTPUTwithdmDisplayFixedOutput = 1.AutoActions copies that current
DEVMODEand changes onlydmPelsWidthanddmPelsHeight. Carrying the fixed-output scaling setting into the native-resolution request can causeChangeDisplaySettingsExto returnDISP_CHANGE_BADMODE.The return value was previously ignored, so the log reported that the resolution was being set even though Windows rejected it.
Validation
Manually validated by the user on Windows 11 with an NVIDIA RTX 5070 Ti and driver 616.92:
Before the fix, the second transition returned
DISP_CHANGE_BADMODE (-2).