Update is Broken while WinGet sits on Manifest PR

[zpqrtbnk]

Description

When a new release appears in GitHub the tool immediately reports it and proposes an upgrade, yet it may take time for the WinGet teams to actually merge the manifest PR. In the meantime, the WinGet upgrade will fail, the tool will abort, this is not pretty.

Environment

• App version (or commit if built from source): 2.15.14
• Installation method (WinGet, portable release, or source): WinGet

Steps to reproduce

Right now version 2.15.14 detects new releases from GitHub but the WinGet upgrade crashes.

Actual behavior

A crash.

Diagnostics or screenshots (optional)

Explained in the description.

What we should do is, in case GitHub reports a new version, also check that it's available on WinGet.

[zpqrtbnk]

PR #145 should fix this. Tested OK locally.

[zpqrtbnk]

There's one thing the PR does not do... that we may want to discuss. Say you keep releasing versions fast enough, we would keep detecting them from GitHub and then reporting them as pending from WinGet... and the user will never be able to upgrade at all.

I see this: v2 is released, v3-8 are available on WinGet, GitHub reports that last version is v9. We tell the user that v9 is the latest release but not available for now. It's a bit sad, we could propose to upgrade to v8. Worse, if the release frequency is high enough, the user will never ever upgrade.

I realized this right after pushing the PR. I'm going to have another look at the problem.

[zpqrtbnk]

Have pushed a commit to the PR. Now assuming that 2.15.17 is the latest version on WinGet, and 2.15.19 is the latest GitHub release,

• 2.15.17 installed = "2.15.19 exists but n/a, try again later"
• 2.15.14 installed = "2.15.19 exists but n/a, OTOH 2.15.17 is available, want to upgrade?"

Which means a user will be prompted to install to the latest version available on WinGet.

And then... why bother with GitHub releases at all when the upgrade channel is WinGet? Should we just stop reading GitHub in this case and work with WinGet exclusively? I leave it up to your decision, I think it is still nice to see that a new version exists, even if not immediately available.