Glasgow | 26- SDC-Mar | Taras Mykytiuk | Sprint 5 | Prep exercises#514
Open
TarasMykytiuk wants to merge 11 commits into
Open
Glasgow | 26- SDC-Mar | Taras Mykytiuk | Sprint 5 | Prep exercises#514TarasMykytiuk wants to merge 11 commits into
TarasMykytiuk wants to merge 11 commits into
Conversation
TarasMykytiuk
added
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
6 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
TarasMykytiuk
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
TarasMykytiuk
changed the title
TarasMykytiuk
added
the
Needs Review
LonMcGregor
added
the
Review in progress
LonMcGregor
reviewed
May 13, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
Contributor
There was a problem hiding this comment.
Good work on these. A few issues in some of the files, see my comments for more info
Contributor
There was a problem hiding this comment.
You don't need to commit these files, can you remove it / ignore it?
| def is_adult(self) -> bool: | ||
| current_date = date.today() | ||
| full_years = current_date.year - self.date_of_birth.year | ||
| if (current_date.month < self.date_of_birth.month) or ( |
Contributor
There was a problem hiding this comment.
Is there a simpler way of comparing dates?
|
|
||
| def main(): | ||
| input = inputPerson() | ||
| if len(input) == 0: |
Contributor
There was a problem hiding this comment.
Does your solution appropriately handle if there was an error in the input?
LonMcGregor
added
Reviewed
TarasMykytiuk
added
Needs Review
LonMcGregor
reviewed
Jun 17, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
Contributor
There was a problem hiding this comment.
My comment about the pycache files is not resolved yet, can you take a look there.
You are now printing an error when handling the input, but is that a useful way of using an app, that it immediately exits when invalid input is given? Can you change it to allow a user to re-attempt the input if something is broken?
LonMcGregor
added
Reviewed
TarasMykytiuk
added
Needs Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Prep exercises for sprint 5 are done.