Skip to content

Automate testing of initial sprints in tools module#472

Open
LonMcGregor wants to merge 29 commits intoCodeYourFuture:mainfrom
LonMcGregor:main
Open

Automate testing of initial sprints in tools module#472
LonMcGregor wants to merge 29 commits intoCodeYourFuture:mainfrom
LonMcGregor:main

Conversation

@LonMcGregor
Copy link
Copy Markdown

@LonMcGregor LonMcGregor commented Apr 7, 2026

  • Expected output now in expected folder
  • Github action which runs after validation, when Needs Review
  • Script that can be run to test locally before push
  • Split number sys qs into automatable/manualy checkable

@LonMcGregor LonMcGregor marked this pull request as draft April 7, 2026 15:19
@LonMcGregor LonMcGregor marked this pull request as ready for review April 8, 2026 13:06
Copy link
Copy Markdown
Member

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks really good, and very useful!

One thing I really like about the metadata validator one that this doesn't do is collapse old comments... I just put together CodeYourFuture/trainee-tracker#68 so that we can just run a standalone binary to close existing comments - if we add <!--CYFTT tag: sdc-test-results--> somewhere in the comment we leave, we can use that binary to minimise past comments. WDYT?

Comment thread .github/workflows/test-sdc-tasks.yml Outdated
Comment thread .github/workflows/test-sdc-tasks.yml Outdated
Comment thread test-sdc.sh Outdated
Comment thread test-sdc.sh Outdated
Comment thread test-sdc.sh
@LonMcGregor LonMcGregor added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Apr 29, 2026
@LonMcGregor
Copy link
Copy Markdown
Author

I think I've got it working now. I've tested a fork in my repo and it seems to be working well. But because the action setup is tricky I won't know if it actually fully works until it's merged and I can do a full run through of solving a task using a fork from this repo. One thing I'm not sure of is how this is going to impact people who have already forked this repo - when they submit, it should skip past any irrelevant tasks, but for the handful that still haven't submitted these early tasks it might cause a problem because their repo won't have the right files in it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants