Skip to content

Glasgow | 26- SDC-Mar | Rahma Berhan | Sprint 1 | Number Systems#470

Open
RahmaB1 wants to merge 6 commits intoCodeYourFuture:mainfrom
RahmaB1:main
Open

Glasgow | 26- SDC-Mar | Rahma Berhan | Sprint 1 | Number Systems#470
RahmaB1 wants to merge 6 commits intoCodeYourFuture:mainfrom
RahmaB1:main

Conversation

@RahmaB1
Copy link
Copy Markdown

@RahmaB1 RahmaB1 commented Apr 6, 2026 •
edited
Loading

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Answers to questions in Readme file

@github-actions

This comment has been minimized.

Sign in to view
@RahmaB1 RahmaB1 added 📅 Sprint 1 Assigned during Sprint 1 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Apr 6, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 6, 2026
@github-actions

This comment has been minimized.

Sign in to view
4 similar comments
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@RahmaB1 RahmaB1 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 6, 2026
SlideGauge
SlideGauge reviewed Apr 17, 2026
View reviewed changes
Copy link
Copy Markdown

@SlideGauge SlideGauge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You committed also shell tools tasks, please, review it

SlideGauge
SlideGauge reviewed Apr 17, 2026
View reviewed changes
Comment thread number-systems/README.md
Convert the decimal number 14 to binary.
Answer:
Answer:
1100
Copy link
Copy Markdown

@SlideGauge SlideGauge Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 * 2^3 + 1 * 2^2 + 0 * 2^1 + 0 * 2^0 = 12, not 14

Comment thread number-systems/README.md

How many bits would you need in order to store the numbers between 0 and 1000 inclusive?
Answer:

Copy link
Copy Markdown

@SlideGauge SlideGauge Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The answer is missing

Comment thread number-systems/README.md
@@ -38,28 +45,39 @@
Answer:

Copy link
Copy Markdown

@SlideGauge SlideGauge Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The answer is missing

@SlideGauge SlideGauge added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Apr 17, 2026
@SlideGauge
Copy link
Copy Markdown

SlideGauge commented Apr 17, 2026

Please, address my notes

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 17, 2026

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^number-systems/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

1 similar comment
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 17, 2026

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^number-systems/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@SlideGauge SlideGauge SlideGauge left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Reviewed Volunteer to add when completing a review with trainee action still to take. 📅 Sprint 1 Assigned during Sprint 1 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@RahmaB1 @SlideGauge