NW | 2026-mar-sdc | Ahmad Hmedan | Sprint 1 | individual-Shell-tools#374
Open
AhmadHmedann wants to merge 2 commits intoCodeYourFuture:mainfrom
Open
NW | 2026-mar-sdc | Ahmad Hmedan | Sprint 1 | individual-Shell-tools#374AhmadHmedann wants to merge 2 commits intoCodeYourFuture:mainfrom
AhmadHmedann wants to merge 2 commits intoCodeYourFuture:mainfrom
Conversation
This comment has been minimized.
This comment has been minimized.
AhmadHmedann
added
the
Needs Review
AhmadHmedann
changed the title
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
4 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
AhmadHmedann
added
the
Needs Review
SlideGauge
reviewed
Apr 13, 2026
SlideGauge
left a comment
SlideGauge
left a comment
There was a problem hiding this comment.
Looks like cat/script-01.sh is missing, could you add it?
Also, could you doublecheck the settings of your editor, your files miss the trailiing new line
| # 3 It looked delicious. | ||
| # 4 I was tempted to take a bite of it. | ||
| # 5 But this seemed like a bad idea... | ||
| cat -n ../helper-files/*.txt No newline at end of file |
There was a problem hiding this comment.
Will this command indeed produce line numbers which are not reset on each new file?
| # TODO: Write a command to output just the names of each player along with the number of times they've played the game. | ||
| # Your output should contain 6 lines, each with one word and one number on it. | ||
| # The first line should be "Ahmed 3". | ||
| awk '{print $1, NF-2}' scores-table.txt No newline at end of file |
There was a problem hiding this comment.
Using NF-2 inline (no variable needed) is clean and concise, like
|
I've got a couple of notes, could you fix them please? |
SlideGauge
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
I have answered all the scripts