Skip to content

Sheffield | 2026-MAR-SDC | Jak Rhodes-Smith | Sprint 2 | Shell pipelines#340

Closed
jakr-s wants to merge 4 commits intoCodeYourFuture:mainfrom
jakr-s:shell-pipelines
Closed

Sheffield | 2026-MAR-SDC | Jak Rhodes-Smith | Sprint 2 | Shell pipelines#340
jakr-s wants to merge 4 commits intoCodeYourFuture:mainfrom
jakr-s:shell-pipelines

Conversation

@jakr-s
Copy link
Copy Markdown

@jakr-s jakr-s commented Mar 9, 2026

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Completed all exercises contained in /shell-pipelines

@jakr-s jakr-s added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 11, 2026
Copy link
Copy Markdown

@SlideGauge SlideGauge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add trailing new line to each file please? Otherwise, good job, just add lines and I'll accept it.

Comment thread shell-pipelines/tr/script-02.sh Outdated
@SlideGauge SlideGauge added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Apr 26, 2026
@jakr-s
Copy link
Copy Markdown
Author

jakr-s commented Apr 27, 2026

Added the trailing new line to all of the exercises, thanks for the review 😀

@jakr-s jakr-s added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Apr 27, 2026
@SlideGauge SlideGauge added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Apr 27, 2026
@SlideGauge
Copy link
Copy Markdown

Complete!

@jakr-s jakr-s closed this Apr 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants