Cape Town | 26-ITP-Sep | Quentin Gwele | Sprint 1 | format-clock-edge-cases

[lwandogwele52-ui]

Learners, PR Template

Self checklist

• I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
• My changes meet the requirements of the task
• I have tested my changes
• My changes follow the style guide

Task code

CYF-1197

Changelist

• Added tests for edge cases of formatAs12HourClock: midnight hour (00:xx), early morning, noon hour (12:xx), afternoon, and late evening
• Fixed the function so minutes from the input are kept (previously pm times always showed ":00")
• Fixed hours so they are always padded to two digits (e.g. "01:00 pm")
• Fixed midnight and noon: "00:15" now returns "12:15 am" and "12:30" returns "12:30 pm"
• All tests pass with npm test

[Luro91]

Well done the code works correctly and the tests cover the edge cases

[Luro91]

You don't need to change this. Sometimes it can be helpful to add helper variables to make the code easier to read. In this case the ${String(hours12).padStart(2, "0")} part could be extracted into another variables.