London | 26-ITP-Sep | Bartosz Kawiak | Sprint 3 | dead-code

[bartoszkawiak]

Learners, PR Template

Self checklist

• I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
• My changes meet the requirements of the task
• I have tested my changes
• My changes follow the style guide

Task code

CYF-1066

Changelist

Removed unreachable, redundant, and unused code from the exercises while keeping the functions working as expected.

[abdishakoor-dev]

Only the dead code is gone and both files print exactly what they did before. Returning greetingStr instead of building the same string a second time is a tidy choice. Marking this Complete.

Two optional things:

1. In exercise-1.js, "Jerry" on line 4 is stored but never read, because line 12 replaces it with "Aman" before anything uses testName. Could lines 4 and 12 become a single line?
2. The line you removed used a template literal, `${greeting}, ${name}!`. Both give the same result, but template literals are usually easier to read, because you can see the shape of the final string. Which would you keep if you did this again?